[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36841: [SPARK-39444][SQL] Add OptimizeSubqueries into nonExcludableRules list

2022-06-13 Thread GitBox 


HyukjinKwon commented on code in PR #36841:
URL: https://github.com/apache/spark/pull/36841#discussion_r896274952


##
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##
@@ -4456,6 +4456,24 @@ class SQLQuerySuite extends QueryTest with 
SharedSparkSession with AdaptiveSpark
 """.stripMargin),
   Seq(Row(2), Row(1)))
   }
+
+  test("SPARK-39444: Add OptimizeSubqueries into nonExcludableRules list") {
+withSQLConf(
+  SQLConf.OPTIMIZER_EXCLUDED_RULES.key ->
+
"org.apache.spark.sql.catalyst.optimizer.Optimizer$OptimizeSubqueries") {

Review Comment:
   and let's match the test place with 
https://github.com/apache/spark/pull/36847



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36841: [SPARK-39444][SQL] Add OptimizeSubqueries into nonExcludableRules list

2022-06-13 Thread GitBox 


HyukjinKwon commented on code in PR #36841:
URL: https://github.com/apache/spark/pull/36841#discussion_r896274142


##
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##
@@ -4456,6 +4456,24 @@ class SQLQuerySuite extends QueryTest with 
SharedSparkSession with AdaptiveSpark
 """.stripMargin),
   Seq(Row(2), Row(1)))
   }
+
+  test("SPARK-39444: Add OptimizeSubqueries into nonExcludableRules list") {
+withSQLConf(
+  SQLConf.OPTIMIZER_EXCLUDED_RULES.key ->
+
"org.apache.spark.sql.catalyst.optimizer.Optimizer$OptimizeSubqueries") {

Review Comment:
   nit but can we use a class reference instead of a string?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org