[GitHub] [spark] HyukjinKwon commented on a diff in pull request #43024: [SPARK-45246][BUILD][PS] Encourage using latest `jinja2` other than documentation build
HyukjinKwon commented on code in PR #43024: URL: https://github.com/apache/spark/pull/43024#discussion_r1333832303 ## dev/requirements.txt: ## @@ -34,7 +35,9 @@ pydata_sphinx_theme ipython nbsphinx numpydoc -jinja2<3.0.0 +# Commented this because we need the latest version of jinja2 for Pandas API on Spark. +# Please manually install jinja2<3.0.0 when building the documentation. +# jinja2<3.0.0 Review Comment: I think we should probably just leave it as is for now, or let the documentation build works with jinja2 3.0.0+ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #43024: [SPARK-45246][BUILD][PS] Encourage using latest `jinja2` other than documentation build
HyukjinKwon commented on code in PR #43024: URL: https://github.com/apache/spark/pull/43024#discussion_r1332556446 ## dev/requirements.txt: ## @@ -34,7 +35,9 @@ pydata_sphinx_theme ipython nbsphinx numpydoc -jinja2<3.0.0 +# Commented this because we need the latest version of jinja2 for Pandas API on Spark. +# Please manually install jinja2<3.0.0 when building the documentation. +# jinja2<3.0.0 Review Comment: > but it's not working for some functionality for Pandas API on Spark from 4.0.0 release. Which functionality does it not work? I think we should better have one version for development if possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org