[GitHub] [spark] HyukjinKwon commented on issue #27242: [SPARK-30534][INFRA] Use mvn in `dev/scalastyle`
HyukjinKwon commented on issue #27242: [SPARK-30534][INFRA] Use mvn in `dev/scalastyle` URL: https://github.com/apache/spark/pull/27242#issuecomment-576955660 Done, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27242: [SPARK-30534][INFRA] Use mvn in `dev/scalastyle`
HyukjinKwon commented on issue #27242: [SPARK-30534][INFRA] Use mvn in `dev/scalastyle` URL: https://github.com/apache/spark/pull/27242#issuecomment-576590429 I am going to revert this PR for two reasons: - We found an easier way to work around. - It will probably increases the build time in PR builder. SBT build can reuse the build, which I believe people don't like it in general. IIRC, that's why we didn't run `lint-java` and I had to implement `sbt-checkstyle`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27242: [SPARK-30534][INFRA] Use mvn in `dev/scalastyle`
HyukjinKwon commented on issue #27242: [SPARK-30534][INFRA] Use mvn in `dev/scalastyle` URL: https://github.com/apache/spark/pull/27242#issuecomment-576589529 Okay .. @dongjoon-hyun, it was fixed as of https://github.com/apache/spark/commit/c992716a33d78ce0a9aa78b26f5bdb45c26c2a01. The hard-corded repository is actually in `sbt-pom-reader`: https://github.com/JoshRosen/sbt-pom-reader/blob/v1.0.0-spark/src/main/scala/com/typesafe/sbt/pom/MavenPomResolver.scala#L32 So, looks `central` was being overwritten as `http://...`. That's why accidentally https://github.com/apache/spark/commit/c992716a33d78ce0a9aa78b26f5bdb45c26c2a01 fixed the issue because it adds the same repo but with another ID (not `central`). Seems like it falls back properly to that repo. Let me revert this PR and make another fix to make everybody happy. The goal is to make both Github Action and PR builder pass right? I'll give a shot and fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27242: [SPARK-30534][INFRA] Use mvn in `dev/scalastyle`
HyukjinKwon commented on issue #27242: [SPARK-30534][INFRA] Use mvn in `dev/scalastyle` URL: https://github.com/apache/spark/pull/27242#issuecomment-576540197 @dongjoon-hyun, so, you mean: ``` $ rm -rf ~/.m2/repository/org/apache/apache/18/ $ build/sbt clean ``` still doesn't work? It works in my local even after removing all `.m2`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
