[GitHub] [spark] HyukjinKwon commented on issue #27888: [SPARK-31116][SQL] Fix nested schema case-sensitivity in ParquetRowConverter
HyukjinKwon commented on issue #27888: [SPARK-31116][SQL] Fix nested schema case-sensitivity in ParquetRowConverter URL: https://github.com/apache/spark/pull/27888#issuecomment-599827759 +1, LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27888: [SPARK-31116][SQL] Fix nested schema case-sensitivity in ParquetRowConverter
HyukjinKwon commented on issue #27888: [SPARK-31116][SQL] Fix nested schema case-sensitivity in ParquetRowConverter URL: https://github.com/apache/spark/pull/27888#issuecomment-599394446 Sure, +1 more feedback during the RC and for the advices about tests as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27888: [SPARK-31116][SQL] Fix nested schema case-sensitivity in ParquetRowConverter
HyukjinKwon commented on issue #27888: [SPARK-31116][SQL] Fix nested schema case-sensitivity in ParquetRowConverter URL: https://github.com/apache/spark/pull/27888#issuecomment-599354017 The fix seems fine except the comments above. @dbtsai, WDYT about disabling nested pruning by default for Spark 3.0 (see https://github.com/apache/spark/pull/27888#pullrequestreview-373986169)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org