[GitHub] [spark] HyukjinKwon commented on pull request #33146: [SPARK-35912][SQL] Fix cast struct contains null value to string/struct

2021-06-30 Thread GitBox


HyukjinKwon commented on pull request #33146:
URL: https://github.com/apache/spark/pull/33146#issuecomment-871912905


   Shouldn't it fail instead of setting it as `0`? I feel like the handling 
should be done somewhere in `JacksonParser`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #33146: [SPARK-35912][SQL] Fix cast struct contains null value to string/struct

2021-06-30 Thread GitBox


HyukjinKwon commented on pull request #33146:
URL: https://github.com/apache/spark/pull/33146#issuecomment-871792001


   Hey mind explaining why cast path issue is related to being cached?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org