HyukjinKwon opened a new pull request #32690:
URL: https://github.com/apache/spark/pull/32690


   ### What changes were proposed in this pull request?
   
   This PR proposes to fix and reenable 
`test_stats_on_non_numeric_columns_should_be_discarded_if_numeric_only_is_true` 
that was disabled when we upgrade Python 3.9 in CI at 
https://github.com/apache/spark/pull/32657.
   
   Seems like this is because of the latest NumPy's behaviour change, see also 
`https://github.com/numpy/numpy/pull/16273#discussion_r641264085`.
   
   pandas inherits this behaviour but it doesn't make sense when `numeric_only` 
is set to `True` in pandas. I will track and follow the status of the issue 
between pandas and NumPy.
   
   For the time being, I propose to exclude boolean case alone in 
percentile/quartile test case
   
   ### Why are the changes needed?
   
   To keep the test coverage.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, test-only.
   
   ### How was this patch tested?
   
   I roughly locally tested. But it should pass in CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to