[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-659245767 Now I add another test case which is very similar with the user case in the description. I think it's done. Could you have a chance to review it? @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-659805674 Gentle ping @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-662287457 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-663327849 Hi @cloud-fan @JkSelf , please help to review this PR. I am going to file a new PR for handling three tables SMJ skew which scope is beyond this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654661214 Also this PR can work with #28947 to match more pattern together. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654697631 Yes. You are correct. I have recognized this case. I will should skip aggregation :( This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654698752 To simply the UT. I introduced this pattern. And I have recognized there is problem for agg. I will refactor code and description. Emm. Make it WIP. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
