[GitHub] [spark] LuciferYang commented on pull request #38926: [SPARK-41247][BUILD][FOLLOWUP] Make sbt and maven use the same Protobuf version

2022-12-05 Thread GitBox


LuciferYang commented on PR #38926:
URL: https://github.com/apache/spark/pull/38926#issuecomment-1338694184

   cc @HyukjinKwon @gengliangwang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] LuciferYang commented on pull request #38926: [SPARK-41247][BUILD][FOLLOWUP] Make sbt and maven use the same Protobuf version

2022-12-05 Thread GitBox


LuciferYang commented on PR #38926:
URL: https://github.com/apache/spark/pull/38926#issuecomment-1338704403

   I'm not sure whether [CONNECT] and [PROTOBUF] should be added to this pr, 
should they be added @HyukjinKwon ?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] LuciferYang commented on pull request #38926: [SPARK-41247][BUILD][FOLLOWUP] Make sbt and maven use the same Protobuf version

2022-12-05 Thread GitBox


LuciferYang commented on PR #38926:
URL: https://github.com/apache/spark/pull/38926#issuecomment-1338708081

   Thanks for your confirmation @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] LuciferYang commented on pull request #38926: [SPARK-41247][BUILD][FOLLOWUP] Make sbt and maven use the same Protobuf version

2022-12-05 Thread GitBox


LuciferYang commented on PR #38926:
URL: https://github.com/apache/spark/pull/38926#issuecomment-1338920503

   All test passed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] LuciferYang commented on pull request #38926: [SPARK-41247][BUILD][FOLLOWUP] Make sbt and maven use the same Protobuf version

2022-12-06 Thread GitBox


LuciferYang commented on PR #38926:
URL: https://github.com/apache/spark/pull/38926#issuecomment-1338981866

   Thanks @HyukjinKwon @dongjoon-hyun  @gengliangwang @zhengruifeng @amaliujia 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org