[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-672566297 The main change of Address [5328d33](https://github.com/apache/spark/pull/29370/commits/5328d33cc0fe138a5d1de9c73285ef262209e6dc) is add a sort - Add a `sorted` to ensure `duplicateColumns` string in `SchemaUtils#checkColumnNameDuplication` method error message have a deterministic order because `IterableOps.groupBy` in Scala 2.13 and ` TraversableLike.groupBy` in Scala 2.12 have diffent result order The effect as follow: - Pass `SchemaUtilsSuite ` **Before** ``` Tests: succeeded 4035, failed 17, canceled 0, ignored 6, pending 0 *** 1 SUITE ABORTED *** *** 17 TESTS FAILED *** ``` **After** ``` Tests: succeeded 4035, failed 17, canceled 0, ignored 6, pending 0 *** 1 SUITE ABORTED *** *** 15 TESTS FAILED *** ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Fix some test cases of `sql/catalyst` module in scala 2.13
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-671155276 @srowen agree with u, we can make a 'checkpoint' if [4018b1f](https://github.com/apache/spark/pull/29370/commits/4018b1fb47e72f790609d4d2993e0ba90639fcc8) no problem, and I will update the PR description. I found that It is difficult to fix the cases caused by `WrappedArray`. For example, `WrappedArray.make` method return `WrappedArray` in Scala 2.12 and return `ArraySeq` in Scala 2.13, then in Scala 2.13 `Row.getSeq` method can not convert `ArraySeq` to `Seq` type, the failed cases in `RowEncoderSuite` related to this problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
