[GitHub] [spark] MaxGekk commented on a diff in pull request #38422: [SPARK-40948][SQL] Introduce new error class: DATA_PATH_NOT_EXIST

2022-10-29 Thread GitBox


MaxGekk commented on code in PR #38422:
URL: https://github.com/apache/spark/pull/38422#discussion_r1007996419


##
core/src/main/resources/error/error-classes.json:
##
@@ -98,6 +98,11 @@
   "The value  () cannot be converted to  because it 
is malformed. Correct the value as per the syntax, or change its format. Use 
 to tolerate malformed input and return NULL instead."
 ]
   },
+  "DATA_PATH_NOT_EXIST" : {

Review Comment:
   How about `PATH_NOT_FOUND`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] MaxGekk commented on a diff in pull request #38422: [SPARK-40948][SQL] Introduce new error class: DATA_PATH_NOT_EXIST

2022-10-28 Thread GitBox


MaxGekk commented on code in PR #38422:
URL: https://github.com/apache/spark/pull/38422#discussion_r1007996419


##
core/src/main/resources/error/error-classes.json:
##
@@ -98,6 +98,11 @@
   "The value  () cannot be converted to  because it 
is malformed. Correct the value as per the syntax, or change its format. Use 
 to tolerate malformed input and return NULL instead."
 ]
   },
+  "DATA_PATH_NOT_EXIST" : {

Review Comment:
   How about `NON_EXISTENT_PATH`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org