[GitHub] [spark] MaxGekk commented on pull request #38439: [SPARK-40890][SQL][TESTS] Check error classes in DataSourceV2SQLSuite
MaxGekk commented on PR #38439: URL: https://github.com/apache/spark/pull/38439#issuecomment-1298219391 +1, LGTM. Merging to master. I ran the test locally. Thank you, @panbingkun. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38439: [SPARK-40890][SQL][TESTS] Check error classes in DataSourceV2SQLSuite
MaxGekk commented on PR #38439: URL: https://github.com/apache/spark/pull/38439#issuecomment-1297198690 It seems this is related to your changes: ``` DataSourceV2SQLSuiteV1Filter.MERGE INTO TABLE org.scalatest.exceptions.TestFailedException: "_LEGACY_ERROR_TEMP_2309" did not equal null ``` Most likely after https://github.com/apache/spark/commit/3c967f06e6c37360e53f9c7a5ecff95ae818e713, need to merge/rebase the master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38439: [SPARK-40890][SQL][TESTS] Check error classes in DataSourceV2SQLSuite
MaxGekk commented on PR #38439: URL: https://github.com/apache/spark/pull/38439#issuecomment-1296897444 @panbingkun Please, fix the code style issue: ``` [error] /home/runner/work/spark/spark/sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala: Expected token RPAREN but got Token(EQUALS,=,76130,=) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
