[GitHub] [spark] Ngone51 commented on pull request #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-05-08 Thread GitBox 


Ngone51 commented on pull request #26440:
URL: https://github.com/apache/spark/pull/26440#issuecomment-626088865


   thanks @holdenk . It was me trying to get understand the whole story. I can 
image how decommission performs in Standalone now if the signal is somehow 
controlled manually.
   
   (At the beginning, I was thinking if SIGPWR is from hard-ware failure, then 
no one could escape and even impossible to do decommission.)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] Ngone51 commented on pull request #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-05-08 Thread GitBox 


Ngone51 commented on pull request #26440:
URL: https://github.com/apache/spark/pull/26440#issuecomment-625681613


   > Right so just send SIGPWR to the worker. Are you saying in standalone mode 
you have one worker with multiple executors and you want to decommission a 
specific executor? Regardless this isn’t really the place, how about you go 
back to the PR introducing SIGPWR handler
   
   I am talking about decommission all executors in standalone. IIUC, all 
executors will shutdown at once (because of `WorkerWatcher`) when a worker 
shutdown(e.g. receive SIGPWR) in standalone. So we obviously have no time  or 
it's meaningless to do decommission(cache copy, adding into 
`executorsPendingDecommission` ) for executors.
   
   @holdenk 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org