[GitHub] [spark] Ngone51 commented on pull request #31348: [SPARK-34245][CORE] Ensure Master removes executors that failed to send finished state

2021-02-23 Thread GitBox


Ngone51 commented on pull request #31348:
URL: https://github.com/apache/spark/pull/31348#issuecomment-784245683


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Ngone51 commented on pull request #31348: [SPARK-34245][CORE] Ensure Master removes executors that failed to send finished state

2021-02-23 Thread GitBox


Ngone51 commented on pull request #31348:
URL: https://github.com/apache/spark/pull/31348#issuecomment-784180358


   updated.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Ngone51 commented on pull request #31348: [SPARK-34245][CORE] Ensure Master removes executors that failed to send finished state

2021-02-18 Thread GitBox


Ngone51 commented on pull request #31348:
URL: https://github.com/apache/spark/pull/31348#issuecomment-781760763


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Ngone51 commented on pull request #31348: [SPARK-34245][CORE] Ensure Master removes executors that failed to send finished state

2021-02-18 Thread GitBox


Ngone51 commented on pull request #31348:
URL: https://github.com/apache/spark/pull/31348#issuecomment-781435764


   Sure, just updated.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Ngone51 commented on pull request #31348: [SPARK-34245][CORE] Ensure Master removes executors that failed to send finished state

2021-02-05 Thread GitBox


Ngone51 commented on pull request #31348:
URL: https://github.com/apache/spark/pull/31348#issuecomment-773878666


   cc @cloud-fan @jiangxb1987 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Ngone51 commented on pull request #31348: [SPARK-34245][CORE] Ensure Master removes executors that failed to send finished state

2021-02-05 Thread GitBox


Ngone51 commented on pull request #31348:
URL: https://github.com/apache/spark/pull/31348#issuecomment-773878666


   cc @cloud-fan @jiangxb1987 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Ngone51 commented on pull request #31348: [SPARK-34245][CORE] Ensure Master removes executors that failed to send finished state

2021-02-03 Thread GitBox


Ngone51 commented on pull request #31348:
URL: https://github.com/apache/spark/pull/31348#issuecomment-772955698


   @jiangxb1987 Please take another look, thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Ngone51 commented on pull request #31348: [SPARK-34245][CORE] Ensure Master removes executors that failed to send finished state

2021-01-28 Thread GitBox


Ngone51 commented on pull request #31348:
URL: https://github.com/apache/spark/pull/31348#issuecomment-769621949


   > for example to trigger the schedule() function periodically.
   
   I have considered this approach and think it might not work in the case of 
the `requestedCores` is specified by users. Because the Master thinks those 
leaked executors are alive, so the granted cores for the application are not 
changed. So the application can not have the chance to schedule more executors 
if the granted cores already reach the `requestedCores`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Ngone51 commented on pull request #31348: [SPARK-34245][CORE] Ensure Master removes executors that failed to send finished state

2021-01-26 Thread GitBox


Ngone51 commented on pull request #31348:
URL: https://github.com/apache/spark/pull/31348#issuecomment-767626405


   cc @cloud-fan @jiangxb1987 Please take a look, thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org