[GitHub] [spark] Ngone51 commented on pull request #33118: [WIP][SPARK-35917][SHUFFLE][CORE]Disable push-based shuffle feature to prevent it from being used

2021-06-30 Thread GitBox


Ngone51 commented on pull request #33118:
URL: https://github.com/apache/spark/pull/33118#issuecomment-871147518


   I see. Make sense to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Ngone51 commented on pull request #33118: [WIP][SPARK-35917][SHUFFLE][CORE]Disable push-based shuffle feature to prevent it from being used

2021-06-29 Thread GitBox


Ngone51 commented on pull request #33118:
URL: https://github.com/apache/spark/pull/33118#issuecomment-871067232


I'm thinking that if we dynamically disable push-based shuffle when 
indeterminated stage retries (e.g., via job properties), users are still safe 
to try it? 
   
   (Note that push-based shuffle is already disabled in the case of multiple 
yarn attempts in master branch)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org