[GitHub] [spark] Yikun commented on pull request #32859: [SPARK-35708][PYTHON][TEST] Add BaseTest for DataTypeOps

2021-06-14 Thread GitBox


Yikun commented on pull request #32859:
URL: https://github.com/apache/spark/pull/32859#issuecomment-859342192


   cc @xinrong-databricks @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Yikun commented on pull request #32859: [SPARK-35708][PYTHON][TEST] Add BaseTest for DataTypeOps

2021-06-14 Thread GitBox


Yikun commented on pull request #32859:
URL: https://github.com/apache/spark/pull/32859#issuecomment-861116601


   > Reminder: We might include DecimalOps in the test according to which PR 
(this or #32821) is merged first.
   
   @xinrong-databricks Yep. I'm going to update DecimalOps test case after this 
merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Yikun commented on pull request #32859: [SPARK-35708][PYTHON][TEST] Add BaseTest for DataTypeOps

2021-06-18 Thread GitBox


Yikun commented on pull request #32859:
URL: https://github.com/apache/spark/pull/32859#issuecomment-864314338


   > @Yikun now that #32821 is merged, could you update to add DecimalOps test 
case?
   
   @ueshin Thanks for reminder, done. : )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org