[GitHub] [spark] agrawaldevesh commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling
agrawaldevesh commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-669616977 I am a bit confused by the commit message of the only commit in this PR: "Shutdown executor once we are done decommissioning". Isn't this the recently merged PR https://github.com/apache/spark/pull/29211 (it went to master right) ? Can you make sure that this commit is appropriately rebased on master with a commit like "Use graceful decommissioning as part of dynamic scaling" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] agrawaldevesh commented on pull request #29367: [SPARK-31198][CORE] Use graceful decommissioning as part of dynamic scaling
agrawaldevesh commented on pull request #29367: URL: https://github.com/apache/spark/pull/29367#issuecomment-669666584 > Ah yeah, if you click expand you can see it's just all squished down together into one commit and the full commit text covers everything. When it gets merged the commit message is picked from the title anyways but I'll rename the title line of the commit. It would really help the review if you could please force push the rebased version with the commits properly separated/pruned. Is this PR ready to be reviewed that you can do that ? Thanks ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
