[GitHub] [spark] amanomer commented on issue #26734: [SPARK-30099][SQL] Improve Analyzed Logical Plan
amanomer commented on issue #26734: [SPARK-30099][SQL] Improve Analyzed Logical Plan URL: https://github.com/apache/spark/pull/26734#issuecomment-562439516 cc @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] amanomer commented on issue #26734: [SPARK-30099][SQL] Improve Analyzed Logical Plan
amanomer commented on issue #26734: [SPARK-30099][SQL] Improve Analyzed Logical Plan URL: https://github.com/apache/spark/pull/26734#issuecomment-562067688 https://github.com/apache/spark/blob/332e252a1448a27cfcfc1d1d794f7979e6cd331a/sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala#L135-L154 Hi @cloud-fan @hvanhovell @adipola , I think we can optimize this code as, if some query fails in analysis phase and throws AnalysisException. Further phases of planning will also fail so we can avoid constructing the plan for them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] amanomer commented on issue #26734: [SPARK-30099][SQL] Improve Analyzed Logical Plan
amanomer commented on issue #26734: [SPARK-30099][SQL] Improve Analyzed Logical Plan URL: https://github.com/apache/spark/pull/26734#issuecomment-561543714 Thanks @hvanhovell @cloud-fan @adipola This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] amanomer commented on issue #26734: [SPARK-30099][SQL] Improve Analyzed Logical Plan
amanomer commented on issue #26734: [SPARK-30099][SQL] Improve Analyzed Logical Plan URL: https://github.com/apache/spark/pull/26734#issuecomment-561261443 cc @cloud-fan @srowen This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
