[GitHub] [spark] amirmasoudabdol commented on a change in pull request #34728: [WIP][SPARK-37474][R][DOCS] Migrate SparkR docs to pkgdown

2021-12-02 Thread GitBox


amirmasoudabdol commented on a change in pull request #34728:
URL: https://github.com/apache/spark/pull/34728#discussion_r760917158



##
File path: R/pkg/_pkgdown.yml
##
@@ -0,0 +1,293 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+url: ~
+
+template:
+  package: preferably

Review comment:
   {preferably} now supports {pkgdown} 2.0, and Bootstrap 5! 
   
   It is not yet on CRAN though, I'm waiting for their approval, etc.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] amirmasoudabdol commented on a change in pull request #34728: [WIP][SPARK-37474][R][DOCS] Migrate SparkR docs to pkgdown

2021-12-01 Thread GitBox


amirmasoudabdol commented on a change in pull request #34728:
URL: https://github.com/apache/spark/pull/34728#discussion_r759973118



##
File path: R/pkg/_pkgdown.yml
##
@@ -0,0 +1,293 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+url: ~
+
+template:
+  package: preferably

Review comment:
   I noticed that this issue is linked to my repo, so I thought I would 
come here and say that I'm working on an update to support BS5. In the 
meantime, I just pushed a minor patch that fixes some minor issues from 
upgrading to `{pkgdown} 2.0`! :-)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org