[GitHub] [spark] cloud-fan commented on a change in pull request #26126: [SPARK-27880][SQL] Add support for bool_and and bool_or aggregates
cloud-fan commented on a change in pull request #26126: [SPARK-27880][SQL] Add
support for bool_and and bool_or aggregates
URL: https://github.com/apache/spark/pull/26126#discussion_r335283934
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##
@@ -316,6 +316,8 @@ object FunctionRegistry {
expression[EveryAgg]("every"),
expression[AnyAgg]("any"),
expression[SomeAgg]("some"),
+expression[BoolAnd]("bool_and"),
Review comment:
We don't need to keep the function alias in the schema. There are many
examples in `FunctionRegistry`, that a function has more than one name and we
always use one name when displaying.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #26126: [SPARK-27880][SQL] Add support for bool_and and bool_or aggregates
cloud-fan commented on a change in pull request #26126: [SPARK-27880][SQL] Add
support for bool_and and bool_or aggregates
URL: https://github.com/apache/spark/pull/26126#discussion_r335266748
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##
@@ -316,6 +316,8 @@ object FunctionRegistry {
expression[EveryAgg]("every"),
expression[AnyAgg]("any"),
expression[SomeAgg]("some"),
+expression[BoolAnd]("bool_and"),
Review comment:
is `bool_and` just an alias of `every`? If so we can do
`expression[EveryAgg]("bool_and")`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
