[GitHub] [spark] cloud-fan commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the timestamp pattern in the example for `to_timestamp`
cloud-fan commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4]
Fix the timestamp pattern in the example for `to_timestamp`
URL: https://github.com/apache/spark/pull/27438#discussion_r374095137
##
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##
@@ -2967,7 +2967,7 @@ object functions {
* See [[java.text.SimpleDateFormat]] for valid date and time format patterns
*
* @param s A date, timestamp or string. If a string, the data must be in
a format that can be
- *cast to a timestamp, such as `-MM-dd` or `-MM-dd
HH:mm:ss.`
Review comment:
for 1), is it fixed in 2.4 or not?
for 2), have we documented it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the timestamp pattern in the example for `to_timestamp`
cloud-fan commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4]
Fix the timestamp pattern in the example for `to_timestamp`
URL: https://github.com/apache/spark/pull/27438#discussion_r374061420
##
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##
@@ -2967,7 +2967,7 @@ object functions {
* See [[java.text.SimpleDateFormat]] for valid date and time format patterns
*
* @param s A date, timestamp or string. If a string, the data must be in
a format that can be
- *cast to a timestamp, such as `-MM-dd` or `-MM-dd
HH:mm:ss.`
Review comment:
what's wrong with "."?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
