[GitHub] [spark] cloud-fan commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery.

2019-12-05 Thread GitBox
cloud-fan commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch 
issue for InSubquery.
URL: https://github.com/apache/spark/pull/26485#issuecomment-562016365
 
 
   thanks, merging to master!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery.

2019-12-04 Thread GitBox
cloud-fan commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch 
issue for InSubquery.
URL: https://github.com/apache/spark/pull/26485#issuecomment-561685028
 
 
   How about the other way around (string in decimal)?  Anyway this is already 
the behavior of `In`, we should fix them together later for ANSI-SQL compliant.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery.

2019-12-03 Thread GitBox
cloud-fan commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch 
issue for InSubquery.
URL: https://github.com/apache/spark/pull/26485#issuecomment-561520060
 
 
   LGTM. Can we check the behavior in other databases like pgsql? It's better 
to know if Spark follows SQL standard or not.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org