[GitHub] [spark] cloud-fan commented on issue #26684: [SPARK-30001][SQL] ResolveRelations should handle both V1 and V2 tables.
cloud-fan commented on issue #26684: [SPARK-30001][SQL] ResolveRelations should handle both V1 and V2 tables. URL: https://github.com/apache/spark/pull/26684#issuecomment-562466589 the last commit just renames a method and has passed compilation, the previous commit passes all tests, I'm merging to master, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #26684: [SPARK-30001][SQL] ResolveRelations should handle both V1 and V2 tables.
cloud-fan commented on issue #26684: [SPARK-30001][SQL] ResolveRelations should handle both V1 and V2 tables. URL: https://github.com/apache/spark/pull/26684#issuecomment-562440602 @rdblue there are some history stories here. Spark supports CREATE TEMP VIEW USING, which creates a special temp view that points to a data source table (e.g. a parquet table, a JDBC table). So INSERT INTO needs to support temp views. Maybe we can remove CREATE TEMP VIEW USING too, but that needs more discussion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #26684: [SPARK-30001][SQL] ResolveRelations should handle both V1 and V2 tables.
cloud-fan commented on issue #26684: [SPARK-30001][SQL] ResolveRelations should handle both V1 and V2 tables. URL: https://github.com/apache/spark/pull/26684#issuecomment-562118359 LGTM except https://github.com/apache/spark/pull/26684/files#r354117018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
