[GitHub] [spark] cloud-fan commented on issue #26975: [SPARK-30325][CORE] Stage retry and executor crash cause app hung up forever
cloud-fan commented on issue #26975: [SPARK-30325][CORE] Stage retry and executor crash cause app hung up forever URL: https://github.com/apache/spark/pull/26975#issuecomment-56592 LGTM. Can you update the PR description? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #26975: [SPARK-30325][CORE] Stage retry and executor crash cause app hung up forever
cloud-fan commented on issue #26975: [SPARK-30325][CORE] Stage retry and executor crash cause app hung up forever URL: https://github.com/apache/spark/pull/26975#issuecomment-56423 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #26975: [SPARK-30325][CORE] Stage retry and executor crash cause app hung up forever
cloud-fan commented on issue #26975: [SPARK-30325][CORE] Stage retry and executor crash cause app hung up forever URL: https://github.com/apache/spark/pull/26975#issuecomment-568682889 I don't think it's safe to not reschedule it. Looking at the comment in `executorLost`, we want to reschedule because the shuffle files are all lost in this executor. The special case is `killedByOtherAttempt.contains(tid)`, which means a speculative task has finished on **another executor**. For the stage attempt, there is no guarantee that 2 tasks of the same partition will be run on different executors. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #26975: [SPARK-30325][CORE] Stage retry and executor crash cause app hung up forever
cloud-fan commented on issue #26975: [SPARK-30325][CORE] Stage retry and executor crash cause app hung up forever URL: https://github.com/apache/spark/pull/26975#issuecomment-568672632 I think the direct problem is, the task status is inconsistent: a task can satisfy both `successful(task.index)` and `task.running`. Such tasks will be handled twice in `executorLost` and mess up the internal status. A simple fix can be: change `task.running` to `!successful(task.index) && task.running` in `executorLost` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
