[GitHub] [spark] cloud-fan commented on pull request #31352: [SPARK-34252][SQL] Subquery with view in aggregate's grouping expression fails during the analysis check
cloud-fan commented on pull request #31352: URL: https://github.com/apache/spark/pull/31352#issuecomment-769614946 Hi @imback82 , can you re-open the PR to add the tests? thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31352: [SPARK-34252][SQL] Subquery with view in aggregate's grouping expression fails during the analysis check
cloud-fan commented on pull request #31352: URL: https://github.com/apache/spark/pull/31352#issuecomment-768510068 @imback82 thanks for catching this issue! Since it only affects tests, I don't believe it's a real bug. I think calling a rule in `doCanonicalize` is tricky, so I opened a PR to clean up this: https://github.com/apache/spark/pull/31368 , please take a look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org