[GitHub] [spark] cloud-fan commented on pull request #33079: [SPARK-35888][SQL] Add dataSize field in CoalescedPartitionSpec

2021-06-29 Thread GitBox


cloud-fan commented on pull request #33079:
URL: https://github.com/apache/spark/pull/33079#issuecomment-869681631






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on pull request #33079: [SPARK-35888][SQL] Add dataSize field in CoalescedPartitionSpec

2021-06-28 Thread GitBox


cloud-fan commented on pull request #33079:
URL: https://github.com/apache/spark/pull/33079#issuecomment-870188933


   thanks, merging to master!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on pull request #33079: [SPARK-35888][SQL] Add dataSize field in CoalescedPartitionSpec

2021-06-28 Thread GitBox


cloud-fan commented on pull request #33079:
URL: https://github.com/apache/spark/pull/33079#issuecomment-869681631


   how are we going to use `dataSize`? Only for tests is a bit overkill.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org