[GitHub] [spark] daugraph commented on a change in pull request #34046: [SPARK-36804][YARN] Using the verbose parameter in yarn mode would cause application submission failure
daugraph commented on a change in pull request #34046:
URL: https://github.com/apache/spark/pull/34046#discussion_r714792533
##
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala
##
@@ -66,6 +74,15 @@ private[spark] class ClientArguments(args: Array[String]) {
throw new IllegalArgumentException("Cannot have primary-py-file and
primary-r-file" +
" at the same time")
}
+
+if (verbose) {
+ logInfo("Client arguments for YARN application:")
Review comment:
BTW, print all args is enough indeed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] daugraph commented on a change in pull request #34046: [SPARK-36804][YARN] Using the verbose parameter in yarn mode would cause application submission failure
daugraph commented on a change in pull request #34046:
URL: https://github.com/apache/spark/pull/34046#discussion_r714446941
##
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala
##
@@ -66,6 +74,15 @@ private[spark] class ClientArguments(args: Array[String]) {
throw new IllegalArgumentException("Cannot have primary-py-file and
primary-r-file" +
" at the same time")
}
+
+if (verbose) {
+ logInfo("Client arguments for YARN application:")
Review comment:
we can also avoid throw Expection by remove --verbose option before pass
arguments to org.apache.spark.deploy.yarn.ClientArgument.scala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] daugraph commented on a change in pull request #34046: [SPARK-36804][YARN] Using the verbose parameter in yarn mode would cause application submission failure
daugraph commented on a change in pull request #34046:
URL: https://github.com/apache/spark/pull/34046#discussion_r714445692
##
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala
##
@@ -66,6 +74,15 @@ private[spark] class ClientArguments(args: Array[String]) {
throw new IllegalArgumentException("Cannot have primary-py-file and
primary-r-file" +
" at the same time")
}
+
+if (verbose) {
+ logInfo("Client arguments for YARN application:")
Review comment:
Thanks for your review, your are right, but this is two different
--verbose option. SparkSubmit will pass --verbose option to
org.apache.spark.deploy.yarn.ClientArgument.scala, which can't handle the
--verbose by now. I will add some detailed description of screenshots later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
