[GitHub] [spark] dilipbiswal commented on a change in pull request #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-27 Thread GitBox
dilipbiswal commented on a change in pull request #25525: 
[SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference
URL: https://github.com/apache/spark/pull/25525#discussion_r318283421
 
 

 ##
 File path: docs/sql-ref-syntax-dml-insert-into.md
 ##
 @@ -0,0 +1,199 @@
+---
+layout: global
+title: INSERT INTO
+displayTitle: INSERT INTO
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+ 
+ http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+---
+
+### Description
+
+The `INSERT INTO` statement inserts new rows into a table. The inserted rows 
can be specified by value expressions or result from a query.
+
+See also:
+  * [INSERT OVERWRITE 
statement](sql-ref-syntax-dml-insert-overwrite-table.html)
+  * [INSERT OVERWRITE DIRECTORY 
statement](sql-ref-syntax-dml-insert-overwrite-directory.html)
+  * [INSERT OVERWRITE DIRECTORY with Hive format 
statement](sql-ref-syntax-dml-insert-overwrite-directory-hive.html)
+
+
+### Syntax
+{% highlight sql %}
+INSERT INTO [ TABLE ] table_name
+[ PARTITION ( partition_col_name [ = partition_col_val ] [ , ... ] ) ]
+{ { VALUES ( { value | NULL } [ , ... ] ) [ , ( ... ) ] } | query }
+{% endhighlight %}
+
+### Parameters
+ ***table_name***:
+The name of an existing table.
+
+ ***PARTITION ( partition_col_name [ = partition_col_val ] [ , ... ] )***:
+Specifies one or more partition column and value pairs. The partition value is 
optional.
+
+ ***VALUES ( { value | NULL } [ , ... ] ) [ , ( ... ) ]***:
+Specifies the values to be inserted. Either an explicitly specified value or a 
NULL can be inserted. A comma must be used to seperate each value in the 
clause. More than one set of values can be specified to insert multiple rows.
+
+ ***query***:
+A query that produces the rows to be inserted. It can be in one of following 
formats:
+- a `SELECT` statement
+- a table
 
 Review comment:
   `TABLE` statement ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dilipbiswal commented on a change in pull request #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-27 Thread GitBox
dilipbiswal commented on a change in pull request #25525: 
[SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference
URL: https://github.com/apache/spark/pull/25525#discussion_r318282884
 
 

 ##
 File path: docs/sql-ref-syntax-dml-insert-into.md
 ##
 @@ -0,0 +1,199 @@
+---
+layout: global
+title: INSERT INTO
+displayTitle: INSERT INTO
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+ 
+ http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+---
+
+### Description
+
+The `INSERT INTO` statement inserts new rows into a table. The inserted rows 
can be specified by value expressions or result from a query.
+
+See also:
 
 Review comment:
   @huaxingao Do you think a "see also" or "Related statements (i have used 
this)" will be better at the end of the page ? After reading the description, 
personally i would prefer to see the syntax.  What do you think ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dilipbiswal commented on a change in pull request #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-27 Thread GitBox
dilipbiswal commented on a change in pull request #25525: 
[SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference
URL: https://github.com/apache/spark/pull/25525#discussion_r318277263
 
 

 ##
 File path: docs/sql-ref-syntax-dml-insert-overwrite-directory-hive.md
 ##
 @@ -0,0 +1,66 @@
+---
+layout: global
+title: INSERT OVERWRITE DIRECTORY with Hive format
+displayTitle: INSERT OVERWRITE DIRECTORY with Hive format
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+ 
+ http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+---
+
+### Description
+The `INSERT OVERWRITE DIRECTORY` with Hive format overwrites the existing data 
in the directory with the new values using Hive `SERDE`.
+Hive support must be enabled to use this command. The inserted rows can be 
specified by value expressions or result from a query.
+
+See also:
+  * [INSERT INTO statement](sql-ref-syntax-dml-insert-into.html)
+  * [INSERT OVERWRITE 
statement](sql-ref-syntax-dml-insert-overwrite-table.html)
+  * [INSERT OVERWRITE DIRECTORY 
statement](sql-ref-syntax-dml-insert-overwrite-directory.html)
+
+### Syntax
+{% highlight sql %}
+INSERT OVERWRITE [ LOCAL ] DIRECTORY directory_path
+   [ ROW FORMAT row_format ] [ STORED AS file_format ]
+   { { VALUES ( { value | NULL } [ , ... ] ) [ , ( ... ) ] } | query }
+{% endhighlight %}
+
+### Parameters
+ ***directory_path***:
+Specifies the destination directory.
+
+ ***row_format***:
+Specifies the row format for this insert. `SERDE` clause can be used to 
specify a custom `SERDE` for this insert. Alternatively, `DELIMITED` clause can 
be used to specify the native `SERDE` and state the delimiter, escape 
character, null character, and so on.
 
 Review comment:
   @huaxingao In here we specify the `SERDE` clause. How do we correlate this 
to the syntax diagram ? Is "ROW FORMAT" same as the "SERDE" clause ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dilipbiswal commented on a change in pull request #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-27 Thread GitBox
dilipbiswal commented on a change in pull request #25525: 
[SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference
URL: https://github.com/apache/spark/pull/25525#discussion_r318272870
 
 

 ##
 File path: docs/sql-ref-syntax-dml-insert-into.md
 ##
 @@ -0,0 +1,199 @@
+---
+layout: global
+title: INSERT INTO
+displayTitle: INSERT INTO
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+ 
+ http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+---
+
+### Description
+
+The `INSERT INTO` statement inserts new rows into a table. The inserted rows 
can be specified by value expressions or result from a query.
+
+See also:
+  * [INSERT OVERWRITE 
statement](sql-ref-syntax-dml-insert-overwrite-table.html)
+  * [INSERT OVERWRITE DIRECTORY 
statement](sql-ref-syntax-dml-insert-overwrite-directory.html)
+  * [INSERT OVERWRITE DIRECTORY with Hive format 
statement](sql-ref-syntax-dml-insert-overwrite-directory-hive.html)
+
+
+### Syntax
+{% highlight sql %}
+INSERT INTO [ TABLE ] table_name
+[ PARTITION ( partition_col_name [ = partition_col_val ] [ , ... ] ) ]
+{ { VALUES ( { value | NULL } [ , ... ] ) [ , ( ... ) ] } | query }
+{% endhighlight %}
+
+### Parameters
+ ***table_name***:
+The name of an existing table.
+
+ ***PARTITION ( partition_col_name [ = partition_col_val ] [ , ... ] )***:
+Specifies one or more partition column and value pairs. The partition value is 
optional.
+
+ ***VALUES ( { value | NULL } [ , ... ] ) [ , ( ... ) ]***:
+Specifies the values to be inserted. Either an explicitly specified value or a 
NULL can be inserted. A comma must be used to seperate each value in the 
clause. More than one set of values can be specified to insert multiple rows.
+
+ ***query***:
+A query that produces the rows to be inserted. It can be in one of following 
formats:
+- a `SELECT` statement
+- a table
+- a `FROM` statement
+
+### Examples
+ Single Row Insert Using a VALUES Clause
+{% highlight sql %}
+ CREATE TABLE students (Name VARCHAR(64), Address VARCHAR(64), StudentID INT)
 
 Review comment:
   @huaxingao The SQLs in the example, should we terminate with a semi colon ? 
In case users would like to cut-paste into the shell ? What do you think ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dilipbiswal commented on a change in pull request #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-22 Thread GitBox
dilipbiswal commented on a change in pull request #25525: 
[SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference
URL: https://github.com/apache/spark/pull/25525#discussion_r316985567
 
 

 ##
 File path: docs/sql-ref-syntax-dml-insert-into.md
 ##
 @@ -0,0 +1,65 @@
+---
+layout: global
+title: INSERT INTO
+displayTitle: INSERT INTO
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+ 
+ http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+---
+
+### Description
+
+The `INSERT INTO` statement inserts new rows into a table. The inserted rows 
can be specified by value expressions, or resulted from a query.
+
+### Syntax
+{% highlight sql %}
+INSERT INTO [TABLE] [db_name.]table_name [partition_spec] value_clause | query
+
+partition_spec:
+: (part_col_name1[=val1] [, part_col_name2[=val2], ...])
+
+value_clause:
+: VALUES values_row [, values_row ...]
+
+values_row:
+: (val1 [, val2, ...])
+
+{% endhighlight %}
+
+### Examples
+{% highlight sql %}
+ CREATE TABLE employees (name VARCHAR(64), age INT, salary DECIMAL(9,2))
+   USING PARQUET PARTITIONED BY (age)
+
+ INSERT INTO employees
+   VALUES ('Amy Smith', 35, 20.00)
+
+ INSERT INTO employees PARTITION (age = 35)
+   SELECT * FROM candidates WHERE name = "Bob Doe"
+{% endhighlight %}
+
+### Parameters
+
+ ***table_name***:
+The name of an existing table.
+
+ ***partition_spec***:
+Partition column specification.
+
+ ***value_clause***:
+Specify the values to be inserted.
+
+ ***query***:
+A `SELECT` statement that provides the rows to be inserted.
 
 Review comment:
   @huaxingao would `produces` sound better ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dilipbiswal commented on a change in pull request #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-22 Thread GitBox
dilipbiswal commented on a change in pull request #25525: 
[SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference
URL: https://github.com/apache/spark/pull/25525#discussion_r316985216
 
 

 ##
 File path: docs/sql-ref-syntax-dml-insert-into.md
 ##
 @@ -0,0 +1,65 @@
+---
+layout: global
+title: INSERT INTO
+displayTitle: INSERT INTO
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+ 
+ http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+---
+
+### Description
+
+The `INSERT INTO` statement inserts new rows into a table. The inserted rows 
can be specified by value expressions, or resulted from a query.
+
+### Syntax
+{% highlight sql %}
+INSERT INTO [TABLE] [db_name.]table_name [partition_spec] value_clause | query
 
 Review comment:
   @huaxingao Can you please check the grammar. I think we allow more cases .. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dilipbiswal commented on a change in pull request #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-22 Thread GitBox
dilipbiswal commented on a change in pull request #25525: 
[SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference
URL: https://github.com/apache/spark/pull/25525#discussion_r316985359
 
 

 ##
 File path: docs/sql-ref-syntax-dml-insert-into.md
 ##
 @@ -0,0 +1,65 @@
+---
+layout: global
+title: INSERT INTO
+displayTitle: INSERT INTO
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+ 
+ http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+---
+
+### Description
+
+The `INSERT INTO` statement inserts new rows into a table. The inserted rows 
can be specified by value expressions, or resulted from a query.
+
+### Syntax
+{% highlight sql %}
+INSERT INTO [TABLE] [db_name.]table_name [partition_spec] value_clause | query
+
+partition_spec:
+: (part_col_name1[=val1] [, part_col_name2[=val2], ...])
+
+value_clause:
+: VALUES values_row [, values_row ...]
+
+values_row:
+: (val1 [, val2, ...])
+
+{% endhighlight %}
+
+### Examples
+{% highlight sql %}
+ CREATE TABLE employees (name VARCHAR(64), age INT, salary DECIMAL(9,2))
+   USING PARQUET PARTITIONED BY (age)
+
+ INSERT INTO employees
+   VALUES ('Amy Smith', 35, 20.00)
+
+ INSERT INTO employees PARTITION (age = 35)
+   SELECT * FROM candidates WHERE name = "Bob Doe"
+{% endhighlight %}
 
 Review comment:
   @huaxingao If we determine that we allow more syntax flavors .. could we 
please add one test for each ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dilipbiswal commented on a change in pull request #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-22 Thread GitBox
dilipbiswal commented on a change in pull request #25525: 
[SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference
URL: https://github.com/apache/spark/pull/25525#discussion_r316979104
 
 

 ##
 File path: docs/sql-ref-syntax-dml-insert-into.md
 ##
 @@ -0,0 +1,65 @@
+---
+layout: global
+title: INSERT INTO
+displayTitle: INSERT INTO
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+ 
+ http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+---
+
+### Description
+
+The `INSERT INTO` statement inserts new rows into a table. The inserted rows 
can be specified by value expressions, or resulted from a query.
+
+### Syntax
+{% highlight sql %}
+INSERT INTO [TABLE] [db_name.]table_name [partition_spec] value_clause | query
 
 Review comment:
   @huaxingao 
   Should it be { value_clause | query } 
   or
   ( value_clause | query )


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dilipbiswal commented on a change in pull request #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-22 Thread GitBox
dilipbiswal commented on a change in pull request #25525: 
[SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference
URL: https://github.com/apache/spark/pull/25525#discussion_r316979104
 
 

 ##
 File path: docs/sql-ref-syntax-dml-insert-into.md
 ##
 @@ -0,0 +1,65 @@
+---
+layout: global
+title: INSERT INTO
+displayTitle: INSERT INTO
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+ 
+ http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+---
+
+### Description
+
+The `INSERT INTO` statement inserts new rows into a table. The inserted rows 
can be specified by value expressions, or resulted from a query.
+
+### Syntax
+{% highlight sql %}
+INSERT INTO [TABLE] [db_name.]table_name [partition_spec] value_clause | query
 
 Review comment:
   @huaxingao 
   Should it be { value_clause | query } 
   or
   ( value_clause | query )  ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dilipbiswal commented on a change in pull request #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-22 Thread GitBox
dilipbiswal commented on a change in pull request #25525: 
[SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference
URL: https://github.com/apache/spark/pull/25525#discussion_r316964289
 
 

 ##
 File path: docs/sql-ref-syntax-dml-insert-into.md
 ##
 @@ -0,0 +1,65 @@
+---
+layout: global
+title: INSERT INTO
+displayTitle: INSERT INTO
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+ 
+ http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+---
+
+### Description
+
+The `INSERT INTO` statement inserts new rows into a table. The inserted rows 
can be specified by value expressions, or resulted from a query.
 
 Review comment:
   @huaxingao Wondering if this would sound better ?
   
   The input rows for the `INSERT` statement can be produced by one of two ways 
: 
  - By value expressions
  - By a query


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dilipbiswal commented on a change in pull request #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-22 Thread GitBox
dilipbiswal commented on a change in pull request #25525: 
[SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference
URL: https://github.com/apache/spark/pull/25525#discussion_r316964289
 
 

 ##
 File path: docs/sql-ref-syntax-dml-insert-into.md
 ##
 @@ -0,0 +1,65 @@
+---
+layout: global
+title: INSERT INTO
+displayTitle: INSERT INTO
+license: |
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+ 
+ http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+---
+
+### Description
+
+The `INSERT INTO` statement inserts new rows into a table. The inserted rows 
can be specified by value expressions, or resulted from a query.
 
 Review comment:
   resulted -> resulting ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org