[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24857: [MINOR][CORE] Remove an unused variable in SparkSubmt.scala
dongjoon-hyun commented on a change in pull request #24857: [MINOR][CORE]
Remove an unused variable in SparkSubmt.scala
URL: https://github.com/apache/spark/pull/24857#discussion_r293207010
##
File path: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala
##
@@ -131,13 +129,6 @@ private[ui] class StagePage(parent: StagesTab, store:
AppStatusStore) extends We
return UIUtils.headerSparkPage(request, stageHeader, content, parent)
}
-val storedTasks = store.taskCount(stageData.stageId, stageData.attemptId)
-val numCompleted = stageData.numCompleteTasks
-val totalTasksNumStr = if (totalTasks == storedTasks) {
- s"$totalTasks"
-} else {
- s"$totalTasks, showing $storedTasks"
-}
Review comment:
@imback82 . Before removing lines, please read the commit history. For
example, this is live code. Please see the following PR.
- https://github.com/apache/spark/pull/22525
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24857: [MINOR][CORE] Remove an unused variable in SparkSubmt.scala
dongjoon-hyun commented on a change in pull request #24857: [MINOR][CORE]
Remove an unused variable in SparkSubmt.scala
URL: https://github.com/apache/spark/pull/24857#discussion_r293205670
##
File path:
core/src/main/scala/org/apache/spark/memory/ExecutionMemoryPool.scala
##
@@ -151,7 +151,7 @@ private[memory] class ExecutionMemoryPool(
*/
def releaseMemory(numBytes: Long, taskAttemptId: Long): Unit =
lock.synchronized {
val curMem = memoryForTask.getOrElse(taskAttemptId, 0L)
-var memoryToFree = if (curMem < numBytes) {
+val memoryToFree = if (curMem < numBytes) {
Review comment:
Let's not put the different things in the same PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24857: [MINOR][CORE] Remove an unused variable in SparkSubmt.scala
dongjoon-hyun commented on a change in pull request #24857: [MINOR][CORE]
Remove an unused variable in SparkSubmt.scala
URL: https://github.com/apache/spark/pull/24857#discussion_r293205706
##
File path: core/src/main/scala/org/apache/spark/rdd/CoalescedRDD.scala
##
@@ -364,7 +364,7 @@ private class DefaultPartitionCoalescer(val balanceSlack:
Double = 0.10)
val partNoLocIter = partitionLocs.partsWithoutLocs.iterator
groupArr.filter(pg => pg.numPartitions == 0).foreach { pg =>
while (partNoLocIter.hasNext && pg.numPartitions == 0) {
- var nxt_part = partNoLocIter.next()
+ val nxt_part = partNoLocIter.next()
Review comment:
ditto.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24857: [MINOR][CORE] Remove an unused variable in SparkSubmt.scala
dongjoon-hyun commented on a change in pull request #24857: [MINOR][CORE]
Remove an unused variable in SparkSubmt.scala
URL: https://github.com/apache/spark/pull/24857#discussion_r293205471
##
File path:
core/src/main/scala/org/apache/spark/deploy/rest/SubmitRestProtocolMessage.scala
##
@@ -46,9 +46,6 @@ private[rest] abstract class SubmitRestProtocolMessage {
val action: String = messageType
var message: String = null
- // For JSON deserialization
- private def setAction(a: String): Unit = { }
-
Review comment:
This was added from the
[beginning](https://github.com/apache/spark/commit/6ec0cdc14390d4dc45acf31040f21e1efc476fc0#diff-fb39e366f633463136727a6b6d5b832fR52)
and the comment seems to mean this is used. Shall we keep the existing one?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
