[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26919: [SPARK-30280][DOC] Update docs for make Hive 2.3 dependency by default
dongjoon-hyun commented on a change in pull request #26919: [SPARK-30280][DOC] Update docs for make Hive 2.3 dependency by default URL: https://github.com/apache/spark/pull/26919#discussion_r360662731 ## File path: docs/sql-data-sources-hive-tables.md ## @@ -119,15 +119,15 @@ One of the most important pieces of Spark SQL's Hive support is interaction with which enables Spark SQL to access metadata of Hive tables. Starting from Spark 1.4.0, a single binary build of Spark SQL can be used to query different versions of Hive metastores, using the configuration described below. Note that independent of the version of Hive that is being used to talk to the metastore, internally Spark SQL -will compile against Hive 1.2.1 and use those classes for internal execution (serdes, UDFs, UDAFs, etc). +will compile against Hive 2.3.6 and use those classes for internal execution (serdes, UDFs, UDAFs, etc). Review comment: This seems to become `built-in Hive` eventually. +1 for that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26919: [SPARK-30280][DOC] Update docs for make Hive 2.3 dependency by default
dongjoon-hyun commented on a change in pull request #26919: [SPARK-30280][DOC] Update docs for make Hive 2.3 dependency by default URL: https://github.com/apache/spark/pull/26919#discussion_r358606356 ## File path: docs/building-spark.md ## @@ -83,13 +83,10 @@ Example: To enable Hive integration for Spark SQL along with its JDBC server and CLI, add the `-Phive` and `-Phive-thriftserver` profiles to your existing build options. -By default, Spark will use Hive 1.2.1 with the `hadoop-2.7` profile, and Hive 2.3.6 with the `hadoop-3.2` profile. - -# With Hive 1.2.1 support -./build/mvn -Pyarn -Phive -Phive-thriftserver -DskipTests clean package +By default Spark will build with Hive 2.3.6. # With Hive 2.3.6 support -./build/mvn -Pyarn -Phive -Phive-thriftserver -Phadoop-3.2 -DskipTests clean package +./build/mvn -Pyarn -Phive -Phive-thriftserver -DskipTests clean package Review comment: Shall we add the Hive 1.2.1 example back after this for users? ``` # With Hive 1.2.1 support ./build/mvn -Pyarn -Phive -Phive-thriftserver -Phive-1.2 -DskipTests clean package ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26919: [SPARK-30280][DOC] Update docs for make Hive 2.3 dependency by default
dongjoon-hyun commented on a change in pull request #26919: [SPARK-30280][DOC] Update docs for make Hive 2.3 dependency by default URL: https://github.com/apache/spark/pull/26919#discussion_r358606489 ## File path: docs/building-spark.md ## @@ -83,13 +83,10 @@ Example: To enable Hive integration for Spark SQL along with its JDBC server and CLI, add the `-Phive` and `-Phive-thriftserver` profiles to your existing build options. -By default, Spark will use Hive 1.2.1 with the `hadoop-2.7` profile, and Hive 2.3.6 with the `hadoop-3.2` profile. - -# With Hive 1.2.1 support -./build/mvn -Pyarn -Phive -Phive-thriftserver -DskipTests clean package +By default Spark will build with Hive 2.3.6. # With Hive 2.3.6 support -./build/mvn -Pyarn -Phive -Phive-thriftserver -Phadoop-3.2 -DskipTests clean package +./build/mvn -Pyarn -Phive -Phive-thriftserver -DskipTests clean package Review comment: cc @gatorsmile and @srowen This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
