[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox 
dongjoon-hyun commented on a change in pull request #27438: 
[MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and 
`ParseToTimestamp`
URL: https://github.com/apache/spark/pull/27438#discussion_r373940008
 
 

 ##
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
 ##
 @@ -1370,7 +1370,7 @@ case class ParseToDate(left: Expression, format: 
Option[Expression], child: Expr
 }
 
 /**
- * Parses a column to a timestamp based on the supplied format.
+ * Parses a column to a timestamp in the seconds precision based on the 
supplied format.
 
 Review comment:
   Let's not touch this file.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox 
dongjoon-hyun commented on a change in pull request #27438: 
[MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and 
`ParseToTimestamp`
URL: https://github.com/apache/spark/pull/27438#discussion_r373940062
 
 

 ##
 File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
 ##
 @@ -2949,10 +2949,10 @@ object functions {
   def unix_timestamp(s: Column, p: String): Column = withExpr { 
UnixTimestamp(s.expr, Literal(p)) }
 
   /**
-   * Converts to a timestamp by casting rules to `TimestampType`.
+   * Converts to a timestamp by casting rules to `TimestampType` in the 
seconds precision.
 
 Review comment:
   Let's not touch this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox 
dongjoon-hyun commented on a change in pull request #27438: 
[MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and 
`ParseToTimestamp`
URL: https://github.com/apache/spark/pull/27438#discussion_r373944831
 
 

 ##
 File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
 ##
 @@ -2949,10 +2949,10 @@ object functions {
   def unix_timestamp(s: Column, p: String): Column = withExpr { 
UnixTimestamp(s.expr, Literal(p)) }
 
   /**
-   * Converts to a timestamp by casting rules to `TimestampType`.
+   * Converts to a timestamp by casting rules to `TimestampType` in the 
seconds precision.
 
 Review comment:
   Of course, you can do whatever you want with much more details, but I want 
to minimize the change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and `ParseToTimestamp`

2020-02-02 Thread GitBox 
dongjoon-hyun commented on a change in pull request #27438: 
[MINOR][SQL][DOCS][2.4] Fix the descriptions of `to_timestamp` and 
`ParseToTimestamp`
URL: https://github.com/apache/spark/pull/27438#discussion_r373944890
 
 

 ##
 File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
 ##
 @@ -2962,12 +2962,12 @@ object functions {
   }
 
   /**
-   * Converts time string with the given pattern to timestamp.
+   * Converts time string with the given pattern to timestamp in the seconds 
precision.
 
 Review comment:
   Same with the others.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org