[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29346: [SPARK-32524][SQL][TESTS] CachedBatchSerializerSuite should clean up InMemoryRelation.ser

[GitBox]

dongjoon-hyun commented on a change in pull request #29346:
URL: https://github.com/apache/spark/pull/29346#discussion_r464820146



##
File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/CachedBatchSerializerSuite.scala
##
@@ -120,6 +121,11 @@ class CachedBatchSerializerSuite  extends QueryTest with 
SharedSparkSession {
   classOf[TestSingleIntColumnarCachedBatchSerializer].getName)
   }
 
+  protected override def afterAll(): Unit = {

Review comment:
   Got it~ I missed `as well` in your comment.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29346: [SPARK-32524][SQL][TESTS] CachedBatchSerializerSuite should clean up InMemoryRelation.ser

[GitBox]

dongjoon-hyun commented on a change in pull request #29346:
URL: https://github.com/apache/spark/pull/29346#discussion_r464819384



##
File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/CachedBatchSerializerSuite.scala
##
@@ -120,6 +121,11 @@ class CachedBatchSerializerSuite  extends QueryTest with 
SharedSparkSession {
   classOf[TestSingleIntColumnarCachedBatchSerializer].getName)
   }
 
+  protected override def afterAll(): Unit = {

Review comment:
   Oh. It should be here. `beforeAll` will leave the leftover and will 
break the other suite.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29346: [SPARK-32524][SQL][TESTS] CachedBatchSerializerSuite should clean up InMemoryRelation.ser

[GitBox]

dongjoon-hyun commented on a change in pull request #29346:
URL: https://github.com/apache/spark/pull/29346#discussion_r464819452



##
File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/CachedBatchSerializerSuite.scala
##
@@ -120,6 +121,11 @@ class CachedBatchSerializerSuite  extends QueryTest with 
SharedSparkSession {
   classOf[TestSingleIntColumnarCachedBatchSerializer].getName)
   }
 
+  protected override def afterAll(): Unit = {

Review comment:
   Do you want to have both beforeAll and afterAll?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29346: [SPARK-32524][SQL][TESTS] CachedBatchSerializerSuite should clean up InMemoryRelation.ser

[GitBox]

dongjoon-hyun commented on a change in pull request #29346:
URL: https://github.com/apache/spark/pull/29346#discussion_r464819099



##
File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/CachedBatchSerializerSuite.scala
##
@@ -120,6 +121,11 @@ class CachedBatchSerializerSuite  extends QueryTest with 
SharedSparkSession {
   classOf[TestSingleIntColumnarCachedBatchSerializer].getName)
   }
 
+  protected override def afterAll(): Unit = {

Review comment:
   Sure!





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org