[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33099: [SPARK-35904][SQL] Collapse above RebalancePartitions
dongjoon-hyun commented on a change in pull request #33099:
URL: https://github.com/apache/spark/pull/33099#discussion_r659929721
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##
@@ -911,6 +911,11 @@ object CollapseRepartition extends Rule[LogicalPlan] {
// we can remove the child.
case r @ RepartitionByExpression(_, child: RepartitionOperation, _) =>
r.copy(child = child.child)
+
+// Case 3: When a RebalancePartitions has a child of Repartition or
RepartitionByExpression
+// we can remove the child.
Review comment:
Oh, got it. Thank you for reverting, @cloud-fan and @wangyum .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33099: [SPARK-35904][SQL] Collapse above RebalancePartitions
dongjoon-hyun commented on a change in pull request #33099:
URL: https://github.com/apache/spark/pull/33099#discussion_r659929721
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##
@@ -911,6 +911,11 @@ object CollapseRepartition extends Rule[LogicalPlan] {
// we can remove the child.
case r @ RepartitionByExpression(_, child: RepartitionOperation, _) =>
r.copy(child = child.child)
+
+// Case 3: When a RebalancePartitions has a child of Repartition or
RepartitionByExpression
+// we can remove the child.
Review comment:
Oh, got it. Thank you for reverting, @cloud-fan and @wangyum .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33099: [SPARK-35904][SQL] Collapse above RebalancePartitions
dongjoon-hyun commented on a change in pull request #33099:
URL: https://github.com/apache/spark/pull/33099#discussion_r659259391
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##
@@ -1373,16 +1373,18 @@ object RepartitionByExpression {
*/
case class RebalancePartitions(
partitionExpressions: Seq[Expression],
-child: LogicalPlan) extends UnaryNode {
- override def maxRows: Option[Long] = child.maxRows
- override def output: Seq[Attribute] = child.output
+child: LogicalPlan) extends RepartitionOperation {
Review comment:
This looks like a nice refactoring in order to make consistent and
simplify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
