[GitHub] [spark] dongjoon-hyun commented on issue #24620: [SPARK-27737][SQL][test-maven] Upgrade to Hive 2.3.5 for Hive Metastore Client and Hadoop-3.2 profile

2019-05-20 Thread GitBox
dongjoon-hyun commented on issue #24620: [SPARK-27737][SQL][test-maven] Upgrade 
to Hive 2.3.5 for Hive Metastore Client and Hadoop-3.2 profile
URL: https://github.com/apache/spark/pull/24620#issuecomment-494260661
 
 
   Does something fail with `2.3.5`? Before Spark 3.0.0 release, Hive 2.3.5 
seems to be the last and the most stable Hive release. So, shall we catch up at 
this time? It would be great if you do the following.
   - `dev/test-dependencies.sh --replace-manifest`
   - `sql/core/v2.3.4/src` -> `sql/core/v2.3.5/src`
   
   For shortVersion, we use `1.2.1` previously. So, `2.3.5` looks fine to me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #24620: [SPARK-27737][SQL][test-maven] Upgrade to Hive 2.3.5 for Hive Metastore Client and Hadoop-3.2 profile

2019-05-20 Thread GitBox
dongjoon-hyun commented on issue #24620: [SPARK-27737][SQL][test-maven] Upgrade 
to Hive 2.3.5 for Hive Metastore Client and Hadoop-3.2 profile
URL: https://github.com/apache/spark/pull/24620#issuecomment-494251030
 
 
   Is there a reason to use that?
   > How about change hive.version.short to 2.3.0?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #24620: [SPARK-27737][SQL][test-maven] Upgrade to Hive 2.3.5 for Hive Metastore Client and Hadoop-3.2 profile

2019-05-20 Thread GitBox
dongjoon-hyun commented on issue #24620: [SPARK-27737][SQL][test-maven] Upgrade 
to Hive 2.3.5 for Hive Metastore Client and Hadoop-3.2 profile
URL: https://github.com/apache/spark/pull/24620#issuecomment-494237607
 
 
   Ur, @wangyum . During merging, it seems that we missed to upgrade 
`hadoop-3.2` profile properly.
   ```xml
 hadoop-3.2
   ...
   2.3.4
   ```
   Please update `hadoop-3.2` profile and update the manifests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org