[GitHub] [spark] dongjoon-hyun commented on issue #27088: [SPARK-30413][SQL] Avoid WrappedArray roundtrip in GenericArrayData constructor, plus related optimization in ParquetMapConverter

2020-01-19 Thread GitBox
dongjoon-hyun commented on issue #27088: [SPARK-30413][SQL] Avoid WrappedArray 
roundtrip in GenericArrayData constructor, plus related optimization in 
ParquetMapConverter
URL: https://github.com/apache/spark/pull/27088#issuecomment-576088813
 
 
   Merged to master. (The last one is only adding the JDK11 generated result.)
   Thank you again!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #27088: [SPARK-30413][SQL] Avoid WrappedArray roundtrip in GenericArrayData constructor

2020-01-17 Thread GitBox
dongjoon-hyun commented on issue #27088: [SPARK-30413][SQL] Avoid WrappedArray 
roundtrip in GenericArrayData constructor
URL: https://github.com/apache/spark/pull/27088#issuecomment-575726162
 
 
   Thanks, @JoshRosen .


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #27088: [SPARK-30413][SQL] Avoid WrappedArray roundtrip in GenericArrayData constructor

2020-01-17 Thread GitBox
dongjoon-hyun commented on issue #27088: [SPARK-30413][SQL] Avoid WrappedArray 
roundtrip in GenericArrayData constructor
URL: https://github.com/apache/spark/pull/27088#issuecomment-575696033
 
 
   Hi, @JoshRosen . Could you address @maropu 's comment?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #27088: [SPARK-30413][SQL] Avoid WrappedArray roundtrip in GenericArrayData constructor

2020-01-17 Thread GitBox
dongjoon-hyun commented on issue #27088: [SPARK-30413][SQL] Avoid WrappedArray 
roundtrip in GenericArrayData constructor
URL: https://github.com/apache/spark/pull/27088#issuecomment-575694847
 
 
   Thank you for pinging me, @maropu . I'll review today.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org