[GitHub] [spark] dongjoon-hyun commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap and documentation

2020-07-23 Thread GitBox


dongjoon-hyun commented on pull request #29191:
URL: https://github.com/apache/spark/pull/29191#issuecomment-663006491


   Thank you so much, @cloud-fan , @HyukjinKwon , @maropu .
   The last commit is only adding a test case and the new test case passed.
   Also, previously all unit tests passed in GitHub Action. Merged to 
master/3.0.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-23 Thread GitBox


dongjoon-hyun commented on pull request #29191:
URL: https://github.com/apache/spark/pull/29191#issuecomment-662837130


   The PR description is updated accordingly.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox


dongjoon-hyun commented on pull request #29191:
URL: https://github.com/apache/spark/pull/29191#issuecomment-662809395


   Thank you, @cloud-fan  and @maropu .



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on pull request #29191: [SPARK-32364][SQL][FOLLOWUP] Add toMap to return originalMap

2020-07-22 Thread GitBox


dongjoon-hyun commented on pull request #29191:
URL: https://github.com/apache/spark/pull/29191#issuecomment-662764624


   Hi, @cloud-fan and @HyukjinKwon . 
   Sorry, but could you review this follow-up, please?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org