[GitHub] [spark] dongjoon-hyun commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination
dongjoon-hyun commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727329518 Since the last commit is only for commenting and this PR already passed, I merged this. Thanks~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination
dongjoon-hyun commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727282415 Your idea is better and correct because there is no conf yet~ > Yea, but, on second thought, merging this fist looks fine, too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination
dongjoon-hyun commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727280631 @maropu That's a good point. Initially, I thought three steps. 1) we add a benchmark with the baseline first, 2) merge the #30341, 3) update this benchmark in another PR. But, your suggestion also looks good because this PR already have (3). > This will be merged after #30341 finished? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination
dongjoon-hyun commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727271068 Thank you so much for this additional work, @viirya ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
