[GitHub] [spark] dongjoon-hyun commented on pull request #33180: [SPARK-35825][INFRA][FOLLOWUP][test-maven] Increase it in build/mvn script
dongjoon-hyun commented on pull request #33180: URL: https://github.com/apache/spark/pull/33180#issuecomment-872724889 I'll merge this. Please let us know your result when you have some time, @LuciferYang ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33180: [SPARK-35825][INFRA][FOLLOWUP][test-maven] Increase it in build/mvn script
dongjoon-hyun commented on pull request #33180: URL: https://github.com/apache/spark/pull/33180#issuecomment-872723431 Since this is a flaky compilation issue, the above two Maven runs might be insufficient for verification. However, I believe this patch is no harm for the build and only provides the consistency for Maven. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33180: [SPARK-35825][INFRA][FOLLOWUP][test-maven] Increase it in build/mvn script
dongjoon-hyun commented on pull request #33180: URL: https://github.com/apache/spark/pull/33180#issuecomment-872722372 The above Maven run actually passed the compilation on `catalyst` and `sql` which we see the StackOverflowError frequently. Only fails with the following. It seems to be a flaky test. ``` - driver side SQL metrics *** FAILED *** Map(573099 -> "total (min, med, max (stageId: taskId)) 0 ms (0 ms, 0 ms, 0 ms (stage 4.0: task 8))", 573101 -> "2", 573100 -> "1") did not contain key 573169 (SQLAppStatusListenerSuite.scala:590) ``` And, there is another Maven run is still running. - https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140551/testReport -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33180: [SPARK-35825][INFRA][FOLLOWUP][test-maven] Increase it in build/mvn script
dongjoon-hyun commented on pull request #33180: URL: https://github.com/apache/spark/pull/33180#issuecomment-872670375 Increasing to `3g` is our last resort. This PR intentionally aims to adjust within the current memory limit (2g). If there is no way to stabilize our Jenkins, we should go with higher memory. > On the other hand, is -Xmx2g too small for -Xss128m ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33180: [SPARK-35825][INFRA][FOLLOWUP][test-maven] Increase it in build/mvn script
dongjoon-hyun commented on pull request #33180: URL: https://github.com/apache/spark/pull/33180#issuecomment-872669872 Thank you, @LuciferYang ! Yes, it would be great if you can test this locally. I triggered two Jenkins jobs but I'm not sure because of the running timeout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33180: [SPARK-35825][INFRA][FOLLOWUP][test-maven] Increase it in build/mvn script
dongjoon-hyun commented on pull request #33180: URL: https://github.com/apache/spark/pull/33180#issuecomment-872635501 Retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
