[GitHub] [spark] dtenedor commented on a diff in pull request #38418: [SPARK-40944][SQL] Relax ordering constraint for CREATE TABLE column options

[GitBox]

dtenedor commented on code in PR #38418:
URL: https://github.com/apache/spark/pull/38418#discussion_r1010897010


##
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##
@@ -1001,7 +1001,13 @@ createOrReplaceTableColTypeList
 ;
 
 createOrReplaceTableColType
-: colName=errorCapturingIdentifier dataType (NOT NULL)? defaultExpression? 
commentSpec?
+: colName=errorCapturingIdentifier dataType colDefinitionOption*

Review Comment:
   No worries. Yes, this is correct. This PR relaxes the ordering constraint 
such that any combination of those options is considered valid. This makes it 
easier to apply the CREATE TABLE column options.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dtenedor commented on a diff in pull request #38418: [SPARK-40944][SQL] Relax ordering constraint for CREATE TABLE column options

[GitBox]

dtenedor commented on code in PR #38418:
URL: https://github.com/apache/spark/pull/38418#discussion_r1008275592


##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##
@@ -2813,13 +2813,41 @@ class AstBuilder extends 
SqlBaseParserBaseVisitor[AnyRef] with SQLConfHelper wit
   ctx: CreateOrReplaceTableColTypeContext): StructField = withOrigin(ctx) {
 import ctx._
 
+// Check that no duplicates exist among any CREATE TABLE column options 
specified.
+var isNotNull: Option[Boolean] = None

Review Comment:
   That's a good point. We can just name this `nullable` and set it to 
initially `true`, and change it to `false` if the SQL syntax includes `NOT 
NULL`. Updated accordingly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org