[GitHub] [spark] dtenedor commented on pull request #41191: [SPARK-43529][SQL] Support general literal expressions as OPTIONS values in the parser

2023-05-22 Thread via GitHub


dtenedor commented on PR #41191:
URL: https://github.com/apache/spark/pull/41191#issuecomment-1557836990

   This is done, I have deferred the constant folding logic to the analyzer. 
This is ready for another look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dtenedor commented on pull request #41191: [SPARK-43529][SQL] Support general literal expressions as OPTIONS values in the parser

2023-05-20 Thread via GitHub


dtenedor commented on PR #41191:
URL: https://github.com/apache/spark/pull/41191#issuecomment-1556009814

   Update on this: I thought of a simpler way to break apart this work into 
smaller pieces so we can make gradual improvements. Let me make a commit and 
then I can ping this thread again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org