[GitHub] [spark] dzhigimont commented on pull request #40420: [SPARK-42617][PS] Support `isocalendar` from the pandas 2.0.0
dzhigimont commented on PR #40420: URL: https://github.com/apache/spark/pull/40420#issuecomment-1727427143 > @dzhigimont Can we just make the CI pass for now? I can help in the follow-ups after merging this one. > > Seems like the mypy checks is failing for now: > > ``` > starting mypy annotations test... > annotations failed mypy checks: > python/pyspark/pandas/namespace.py:162: error: Cannot assign multiple types to name "_range" without an explicit "Type[...]" annotation [misc] > python/pyspark/pandas/indexes/base.py:2075: error: Unused "type: ignore" comment > python/pyspark/pandas/indexes/base.py:2145: error: Unused "type: ignore" comment > Found 3 errors in 2 files (checked 703 source files) > ``` > > To resolve them: > > * [ ] Remove "type: ignore" comment from python/pyspark/pandas/indexes/base.py:2075 > * [ ] Remove "type: ignore" comment from python/pyspark/pandas/indexes/base.py:2145 > * [ ] Add "# type: ignore" comment to python/pyspark/pandas/namespace.py:162 Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dzhigimont commented on pull request #40420: [SPARK-42617][PS] Support `isocalendar` from the pandas 2.0.0
dzhigimont commented on PR #40420: URL: https://github.com/apache/spark/pull/40420#issuecomment-1727680820 > @dzhigimont Can we just make the CI pass for now? I can help in the follow-ups after merging this one. > > Seems like the mypy checks is failing for now: > > ``` > starting mypy annotations test... > annotations failed mypy checks: > python/pyspark/pandas/namespace.py:162: error: Cannot assign multiple types to name "_range" without an explicit "Type[...]" annotation [misc] > python/pyspark/pandas/indexes/base.py:2075: error: Unused "type: ignore" comment > python/pyspark/pandas/indexes/base.py:2145: error: Unused "type: ignore" comment > Found 3 errors in 2 files (checked 703 source files) > ``` > > To resolve them: > > * [ ] Remove "type: ignore" comment from python/pyspark/pandas/indexes/base.py:2075 > * [ ] Remove "type: ignore" comment from python/pyspark/pandas/indexes/base.py:2145 > * [ ] Add "# type: ignore" comment to python/pyspark/pandas/namespace.py:162 I can't understand when I added Add "# type: ignore" comment to python/pyspark/pandas/namespace.py:162 mypy raised an error unused type: ignore when I deleted it raised `python/pyspark/pandas/namespace.py:161: error: Cannot assign multiple types to name "_range" without an explicit "Type[...]" annotation [misc]` what do you suggest to me? How i can resolve the problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dzhigimont commented on pull request #40420: [SPARK-42617][PS] Support `isocalendar` from the pandas 2.0.0
dzhigimont commented on PR #40420: URL: https://github.com/apache/spark/pull/40420#issuecomment-1699498241 Updated the branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dzhigimont commented on pull request #40420: [SPARK-42617][PS] Support `isocalendar` from the pandas 2.0.0
dzhigimont commented on PR #40420: URL: https://github.com/apache/spark/pull/40420#issuecomment-1692958737 > @dzhigimont Could you proceed this PR if you're still interested on this work? Sure, sorry for the delay I was a little bit overloaded on my work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dzhigimont commented on pull request #40420: [SPARK-42617][PS] Support `isocalendar` from the pandas 2.0.0
dzhigimont commented on PR #40420: URL: https://github.com/apache/spark/pull/40420#issuecomment-1527398713 > Could you resolve mypy check? You can run the static analysis by running `dev/lint-python` locally. @itholic I've fixed the issue with mypy in my changes, but I still see three problems that don't relate to changes. Should I fix them? ``` annotations failed mypy checks: python/pyspark/pandas/namespace.py:162: error: Cannot assign multiple types to name "_range" without an explicit "Type[...]" annotation [misc] python/pyspark/pandas/indexes/base.py:2093: error: unused "type: ignore" comment python/pyspark/pandas/indexes/base.py:2163: error: unused "type: ignore" comment Found 3 errors in 2 files (checked 507 source files) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
