[GitHub] [spark] felixcheung commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

[GitBox]

felixcheung commented on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-727636799


   I’d defer to Hyukjin Kwon
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] felixcheung commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

[GitBox]

felixcheung commented on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-626400503


   Is this a problem with only the new R 4.0.0 release? Maybe Spark doesn’t 
support it for now, if there isn’t a clean (or software license compatible) way 
to do this?
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] felixcheung commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

[GitBox]

felixcheung commented on pull request #28386:
URL: https://github.com/apache/spark/pull/28386#issuecomment-623220355


   Where is the code on deparse1 etc from? It might have license implication.
   
   I think backport.R is implicitly dependent on the alphabetical order of .R 
files, I’d suggest looking at that more closely and formalize the naming 
convention.
   
   There was a different way to do method signature compatibility (you should 
be able to find it), maybe it will work better.
   
   Finally, I think we need more tests for mutate()
   
   
   
   
   
   From: UCB AMPLab 
   Sent: Tuesday, April 28, 2020 11:34:33 AM
   To: apache/spark 
   Cc: Felix Cheung ; Mention 

   Subject: Re: [apache/spark] [SPARK-26199][SPARK-31517][R] fix strategy for 
handling ... names in mutate (#28386)
   
   
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed):
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122011/
   Test PASSed.
   
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on 
GitHub, or 
unsubscribe.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org