[GitHub] [spark] gatorsmile commented on a change in pull request #23732: [SPARK-26389][SS] Add force delete temp checkpoint configuration
gatorsmile commented on a change in pull request #23732: [SPARK-26389][SS] Add
force delete temp checkpoint configuration
URL: https://github.com/apache/spark/pull/23732#discussion_r360750758
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -907,6 +907,12 @@ object SQLConf {
.stringConf
.createOptional
+ val FORCE_DELETE_TEMP_CHECKPOINT_LOCATION =
+buildConf("spark.sql.streaming.forceDeleteTempCheckpointLocation")
Review comment:
cc @Ngone51 could you submit a PR to make a change?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #23732: [SPARK-26389][SS] Add force delete temp checkpoint configuration
gatorsmile commented on a change in pull request #23732: [SPARK-26389][SS] Add
force delete temp checkpoint configuration
URL: https://github.com/apache/spark/pull/23732#discussion_r360749848
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -907,6 +907,12 @@ object SQLConf {
.stringConf
.createOptional
+ val FORCE_DELETE_TEMP_CHECKPOINT_LOCATION =
+buildConf("spark.sql.streaming.forceDeleteTempCheckpointLocation")
Review comment:
Let us follow the other boolean conf naming convention?
`spark.sql.streaming.forceDeleteTempCheckpointLocation.enabled`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
