[GitHub] [spark] gatorsmile commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence

2019-08-08 Thread GitBox
gatorsmile commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, 
pow functions for platform independence
URL: https://github.com/apache/spark/pull/25279#issuecomment-519716494
 
 
   Thanks! @srowen 
   
   cc @rednaxelafx 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] gatorsmile commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence

2019-08-06 Thread GitBox
gatorsmile commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, 
pow functions for platform independence
URL: https://github.com/apache/spark/pull/25279#issuecomment-518915141
 
 
   @srowen Could you show the perf benchmark? The performance regression is 
expected, right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org