[GitHub] [spark] gatorsmile commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

2020-02-08 Thread GitBox
gatorsmile commented on issue #27503: [SPARK-30761]SQL] Nested column pruning 
should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#issuecomment-583805748
 
 
   @viirya How about reverting the original commit 
https://github.com/apache/spark/commit/a0e63b61e7c5d55ae2a9213b95ab1e87ac7c203c 
and then consider how to improve the rule?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] gatorsmile commented on issue #27503: [SPARK-30761]SQL] Nested column pruning should not prune on required child outputs in Generate

2020-02-08 Thread GitBox
gatorsmile commented on issue #27503: [SPARK-30761]SQL] Nested column pruning 
should not prune on required child outputs in Generate
URL: https://github.com/apache/spark/pull/27503#issuecomment-583805648
 
 
   > If a child output is required in a top operator of Generate, we should not 
prune nested fields on it. Otherwise, the accessors on top operator could be 
unresolved.
   
   Do we traverse all the ancestor nodes? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org