[GitHub] [spark] gengliangwang commented on a change in pull request #26107: [SPARK-28885][SQL] Follow ANSI store assignment rules in table insertion by default
gengliangwang commented on a change in pull request #26107: [SPARK-28885][SQL] Follow ANSI store assignment rules in table insertion by default URL: https://github.com/apache/spark/pull/26107#discussion_r341835365 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ## @@ -143,7 +143,19 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession { /** List of test cases to ignore, in lower cases. */ protected def blackList: Set[String] = Set( -"blacklist.sql" // Do NOT remove this one. It is here to test the blacklist functionality. +"blacklist.sql", // Do NOT remove this one. It is here to test the blacklist functionality. +// SPARK-28885 String value is not allowed to be stored as numeric type with +// ANSI store assignment policy. +"postgreSQL/numeric.sql", +"postgreSQL/int2.sql", +"postgreSQL/int4.sql", +"postgreSQL/int8.sql", +"postgreSQL/float4.sql", +"postgreSQL/float8.sql", +// SPARK-28885 String value is not allowed to be stored as date/timestamp type with +// ANSI store assignment policy. +"postgreSQL/date.sql", Review comment: How about changing the timestamp/date values from string literal to timestamp/date literal in those sql files, just as https://github.com/apache/spark/pull/26107/files#diff-431a4d1f056a06e853da8a60c46e9ca0R68 I am not sure about whether there is a guideline in porting the PgSQL test files. Such modifications are allowed, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #26107: [SPARK-28885][SQL] Follow ANSI store assignment rules in table insertion by default
gengliangwang commented on a change in pull request #26107: [SPARK-28885][SQL] Follow ANSI store assignment rules in table insertion by default URL: https://github.com/apache/spark/pull/26107#discussion_r341834925 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ## @@ -143,7 +143,19 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession { /** List of test cases to ignore, in lower cases. */ protected def blackList: Set[String] = Set( -"blacklist.sql" // Do NOT remove this one. It is here to test the blacklist functionality. +"blacklist.sql", // Do NOT remove this one. It is here to test the blacklist functionality. +// SPARK-28885 String value is not allowed to be stored as numeric type with +// ANSI store assignment policy. +"postgreSQL/numeric.sql", +"postgreSQL/int2.sql", +"postgreSQL/int4.sql", +"postgreSQL/int8.sql", +"postgreSQL/float4.sql", +"postgreSQL/float8.sql", +// SPARK-28885 String value is not allowed to be stored as date/timestamp type with +// ANSI store assignment policy. +"postgreSQL/date.sql", Review comment: @maropu I am not sure about that. For PgSQL, it disable inserting string values to numeric columns except for literals. Setting `storeAssignmentPolicy=LEGACY` for all the PgSQL tests seems inaccurate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #26107: [SPARK-28885][SQL] Follow ANSI store assignment rules in table insertion by default
gengliangwang commented on a change in pull request #26107: [SPARK-28885][SQL] Follow ANSI store assignment rules in table insertion by default URL: https://github.com/apache/spark/pull/26107#discussion_r334466301 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcQuerySuite.scala ## @@ -210,7 +210,9 @@ class HiveOrcQuerySuite extends OrcQueryTest with TestHiveSingleton { } } - test("SPARK-23340 Empty float/double array columns raise EOFException") { + // SPARK-28885 String value is not allowed to be stored as numeric type with Review comment: Created https://issues.apache.org/jira/browse/SPARK-29462 for this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #26107: [SPARK-28885][SQL] Follow ANSI store assignment rules in table insertion by default
gengliangwang commented on a change in pull request #26107: [SPARK-28885][SQL] Follow ANSI store assignment rules in table insertion by default URL: https://github.com/apache/spark/pull/26107#discussion_r334462841 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcQuerySuite.scala ## @@ -210,7 +210,9 @@ class HiveOrcQuerySuite extends OrcQueryTest with TestHiveSingleton { } } - test("SPARK-23340 Empty float/double array columns raise EOFException") { + // SPARK-28885 String value is not allowed to be stored as numeric type with Review comment: ``` > spark.sql("select array()") res0: org.apache.spark.sql.DataFrame = [array(): array] ``` I think it makes more sense to make the type of empty array as `array`. How about create a jira for this and disable the test case for now? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org