[GitHub] [spark] hvanhovell commented on pull request #39517: [SPARK-41993][SQL] Move RowEncoder to AgnosticEncoders

2023-01-16 Thread GitBox


hvanhovell commented on PR #39517:
URL: https://github.com/apache/spark/pull/39517#issuecomment-1384708819

   @dongjoon-hyun I am looking at it now. I am not sure if massive is the 
qualification I would use; all of these are likely to be caused by the same 
thing. Feel free to revert if you have too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] hvanhovell commented on pull request #39517: [SPARK-41993][SQL] Move RowEncoder to AgnosticEncoders

2023-01-11 Thread GitBox


hvanhovell commented on PR #39517:
URL: https://github.com/apache/spark/pull/39517#issuecomment-1379453290

   A note for the reviewers. I know that Catalyst tests pass. I have not run 
other tests, so there might still be a few things to iron out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] hvanhovell commented on pull request #39517: [SPARK-41993][SQL] Move RowEncoder to AgnosticEncoders

2023-01-11 Thread GitBox


hvanhovell commented on PR #39517:
URL: https://github.com/apache/spark/pull/39517#issuecomment-1379452378

   @cloud-fan can you take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org