[GitHub] [spark] jsoref commented on pull request #30323: Spelling
jsoref commented on pull request #30323: URL: https://github.com/apache/spark/pull/30323#issuecomment-741488008 See comments by @srowen @cloud-fan on 0ff10b7ee2a13df02ba2ab5c4c5c86851a531c08 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] jsoref commented on pull request #30323: Spelling
jsoref commented on pull request #30323: URL: https://github.com/apache/spark/pull/30323#issuecomment-741414066 I've split out some of the things that I dropped earlier. I'm going to leave the rest alone for now (I've left the ones we might revisit as "unresolved" to make them easier to spot). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] jsoref commented on pull request #30323: Spelling
jsoref commented on pull request #30323: URL: https://github.com/apache/spark/pull/30323#issuecomment-741319257 So, we're left with three commits: * 0ff10b7ee2a13df02ba2ab5c4c5c86851a531c08 - `create` * 6cbd74162a77fdc4c04c867952ec42c6e493288b - `enabled` * d0a58cc5fdb8956f41e2161a5d1f4f6d90c40353 - `filters` I'm going to move `enabled` and `filters` into distinct PRs because I suspect they're more likely to be API breaks. This PR can be closed once `create` (the last commit standing here) is merged. I'm not entirely certain the other two will be merged, and even if they are, they're probably much more complicated than generic `spelling` fixes (as I suspect they'll require shims). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] jsoref commented on pull request #30323: Spelling
jsoref commented on pull request #30323: URL: https://github.com/apache/spark/pull/30323#issuecomment-739987352 Fwiw, these are the [outstanding changes in this PR](https://github.com/jsoref/spark/compare/spelling-sql-core..jsoref:spelling). I expect this PR to be closed with just one commit `create`. And I'll create a distinct PR for `legacy_setops_precedence_enbled` (`enabled`) and `PushedFilers` (`filters`) which, for the time being, I've added to this series. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] jsoref commented on pull request #30323: Spelling
jsoref commented on pull request #30323: URL: https://github.com/apache/spark/pull/30323#issuecomment-735313703 Things I know will remain: * `create` (it spans multiple directories) -- we can address this after the current open PRs resolve (probably using this PR) * `enabled` (`legacy_setops_precedence_enbled` appears to be a public API -- addressing it would be done as its own distinct PR if at all -- one approach is to add a correct spelling making that the preferred and adding a deprecated annotation to the current spelling -- another approach is to just add a comment acknowledging the API botch) I think that's everything, but we'll see. Note to self: I changed one `E.g.` to `For example` (which actually fit w/ a second one that I did the same to earlier), so I'm going to have a merge conflict: resolver=drop. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] jsoref commented on pull request #30323: Spelling
jsoref commented on pull request #30323: URL: https://github.com/apache/spark/pull/30323#issuecomment-728721289 ok, so, part one is merged. `bin`, `repl`, and `streaming` seem to be the next least recently touched... What's do you recommend doing next? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] jsoref commented on pull request #30323: Spelling
jsoref commented on pull request #30323: URL: https://github.com/apache/spark/pull/30323#issuecomment-727642668 So, one thing I noticed, there are a bunch of places where the line length (100 chars) is already violated. My tentative plan is not to fix those (outside of scope). For things where I'm adding a new comment, I'll try to avoid introducing new errors of that category. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] jsoref commented on pull request #30323: Spelling
jsoref commented on pull request #30323: URL: https://github.com/apache/spark/pull/30323#issuecomment-725166959 I presume you mean https://github.com/apache/spark/tree/master/graphx/ ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] jsoref commented on pull request #30323: Spelling
jsoref commented on pull request #30323: URL: https://github.com/apache/spark/pull/30323#issuecomment-725160571 Fine by me This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] jsoref commented on pull request #30323: Spelling
jsoref commented on pull request #30323: URL: https://github.com/apache/spark/pull/30323#issuecomment-725120497 * I can rebase regularly or infrequently (depends on project preference). * I can update my changes regularly or only rarely. -- for large changes like this, the odds of getting conflicts are very high (which is part of why I prefer to work w/ small commits as rebuilding them individually is generally fairly easy) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
