[GitHub] [spark] linhongliu-db commented on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

2020-10-22 Thread GitBox


linhongliu-db commented on pull request #30053:
URL: https://github.com/apache/spark/pull/30053#issuecomment-714383599


   got it. Let's close it for now



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] linhongliu-db commented on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

2020-10-18 Thread GitBox


linhongliu-db commented on pull request #30053:
URL: https://github.com/apache/spark/pull/30053#issuecomment-711473410


   @cloud-fan This PR depends on another 2 fixes in the master branch. Should 
we cherry-pick them?
   https://github.com/apache/spark/pull/29026
   https://github.com/apache/spark/pull/27627



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] linhongliu-db commented on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

2020-10-16 Thread GitBox


linhongliu-db commented on pull request #30053:
URL: https://github.com/apache/spark/pull/30053#issuecomment-709865036


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] linhongliu-db commented on pull request #30053: [SPARK-32816][SQL][3.0] Fix analyzer bug when aggregating multiple distinct DECIMAL columns

2020-10-15 Thread GitBox


linhongliu-db commented on pull request #30053:
URL: https://github.com/apache/spark/pull/30053#issuecomment-709695280


   This PR depends on https://github.com/apache/spark/pull/30052 to pass tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org