[GitHub] [spark] maropu commented on a change in pull request #29034: [SPARK-32219][SQL] Add SHOW CACHED TABLES Command

[GitBox]

maropu commented on a change in pull request #29034:
URL: https://github.com/apache/spark/pull/29034#discussion_r466135375



##
File path: sql/core/src/test/resources/sql-tests/results/show-tables.sql.out
##
@@ -117,6 +117,63 @@ show_t2
 show_t3
 
 
+-- !query
+CACHE TABLE show_t1
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+CACHE TABLE show_t5 AS SELECT 1
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+SHOW CACHED TABLES LIKE 'show_t*'
+-- !query schema
+struct
+-- !query output
+show_t1
+show_t5

Review comment:
   nit: hm, `SQLQueryTestSuite` only outputs table names for the show 
command, so it might be better to add some tests somewhere, too.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] maropu commented on a change in pull request #29034: [SPARK-32219][SQL] Add SHOW CACHED TABLES Command

[GitBox]

maropu commented on a change in pull request #29034:
URL: https://github.com/apache/spark/pull/29034#discussion_r451363450



##
File path: sql/core/src/test/resources/sql-tests/inputs/show-tables.sql
##
@@ -17,6 +17,12 @@ SHOW TABLES LIKE 'show_t1*|show_t2*';
 SHOW TABLES IN showdb 'show_t*';
 SHOW TABLES IN showdb LIKE 'show_t*';
 
+-- SHOW CACHED TABLES
+CACHE TABLE show_t1;

Review comment:
   Could you add test cases for `AS query`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org