[GitHub] [spark] maropu commented on a change in pull request #31419: [SPARK-34311][SQL] PostgresDialect can't treat arrays of some types

2021-02-02 Thread GitBox 


maropu commented on a change in pull request #31419:
URL: https://github.com/apache/spark/pull/31419#discussion_r568360410



##
File path: 
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala
##
@@ -74,7 +74,9 @@ class PostgresIntegrationSuite extends 
DockerJDBCIntegrationSuite {
   .executeUpdate()
 
 conn.prepareStatement("CREATE TABLE st_with_array (c0 uuid, c1 inet, c2 
cidr," +
-  "c3 json, c4 jsonb, c5 uuid[], c6 inet[], c7 cidr[], c8 json[], c9 
jsonb[])")
+  "c3 json, c4 jsonb, c5 uuid[], c6 inet[], c7 cidr[], c8 json[], c9 
jsonb[], c10 xml[], " +

Review comment:
   How about adding tests for non-array cases, e.g., `col xml` and `col 
tsvector`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] maropu commented on a change in pull request #31419: [SPARK-34311][SQL] PostgresDialect can't treat arrays of some types

2021-02-01 Thread GitBox 


maropu commented on a change in pull request #31419:
URL: https://github.com/apache/spark/pull/31419#discussion_r568360410



##
File path: 
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala
##
@@ -74,7 +74,9 @@ class PostgresIntegrationSuite extends 
DockerJDBCIntegrationSuite {
   .executeUpdate()
 
 conn.prepareStatement("CREATE TABLE st_with_array (c0 uuid, c1 inet, c2 
cidr," +
-  "c3 json, c4 jsonb, c5 uuid[], c6 inet[], c7 cidr[], c8 json[], c9 
jsonb[])")
+  "c3 json, c4 jsonb, c5 uuid[], c6 inet[], c7 cidr[], c8 json[], c9 
jsonb[], c10 xml[], " +

Review comment:
   How about adding tests for non-array cases, e.g., `col xml` and `col 
tsvector`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org